Automatically set up "upstream" remote for forks#719
Merged
Conversation
vilmibm
approved these changes
Mar 31, 2020
Contributor
vilmibm
left a comment
There was a problem hiding this comment.
nice!
i'm excited to see the graphql api client in action, thanks for introducing it. should we file a tech debt ticket for explicitly porting over to it?
Contributor
Author
Maybe, but not sure how long would that ticket stay open! Maybe instead we could just try to write all new GraphQL stuff using the library and incrementally port over old stuff when we need to touch the logic. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
gh repo clone-ing a forked repo, the resulting local repo will automatically have an "upstream" git remote added that points to the parent repo of the fork being cloned.Additionally, this PR introduces usage of the https://github.com/shurcooL/githubv4 library for GraphQL requests. Benefits over our hand-rolled GraphQL approach include:
githubv4library declares a Go type for each scalar type defined in GitHub API v4Fixes #620