Make auth refresh more convenient with secure storage#7098
Merged
Conversation
mislav
approved these changes
Mar 7, 2023
Contributor
mislav
left a comment
There was a problem hiding this comment.
This looks good; thanks.
Would we also consider supporting explicitly disabling via --secure-storage=false to quit storing in keyring and write the token to config file instead?
Contributor
Author
|
@mislav I wasn't not planning on supporting that flow. If the user wants to quit storing the token in the keyring using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some convenience functionality to
auth refreshcommand. Now if a user logged in withauth login --secure-storageorauth refresh --secure-storagenext time they useauth refreshthe--secure-storageflag will be implicitly set. Basically, if the token we want to refresh is coming from secure storage we assume that the user wants to continue to use secure storage even if they forgot to add the--secure-storageflag.