Skip to content

Always open new vscode window in gh cs code#7092

Merged
cmbrose merged 2 commits intotrunkfrom
cmbrose/vscode-new-window
Mar 6, 2023
Merged

Always open new vscode window in gh cs code#7092
cmbrose merged 2 commits intotrunkfrom
cmbrose/vscode-new-window

Conversation

@cmbrose
Copy link
Member

@cmbrose cmbrose commented Mar 6, 2023

fixes https://github.com/github/codespaces/issues/12633

There was a recent codespaces vscode extension release which better integrates with vscode's signals to reuse windows or not. Unfortunately, the CLI was sort of relying on the extension NOT integrating correctly for opening vscode and now gh cs code will take over any open vscode window. This change fixes that by always opening a new vscode window.

@cmbrose cmbrose requested a review from a team as a code owner March 6, 2023 22:36
@cmbrose cmbrose changed the title Open new vscode window Always open new vscode window in gh cs code Mar 6, 2023
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Mar 6, 2023
@cliAutomation
Copy link
Collaborator

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

Copy link

@erikaellr erikaellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants