Skip to content

Properly handle C1 control sequences#7079

Merged
samcoe merged 3 commits intotrunkfrom
ascii-2
Mar 7, 2023
Merged

Properly handle C1 control sequences#7079
samcoe merged 3 commits intotrunkfrom
ascii-2

Conversation

@samcoe
Copy link
Contributor

@samcoe samcoe commented Mar 2, 2023

@samcoe samcoe self-assigned this Mar 2, 2023
@samcoe samcoe marked this pull request as ready for review March 2, 2023 23:16
@samcoe samcoe requested a review from a team as a code owner March 2, 2023 23:16
@samcoe samcoe requested review from vilmibm and removed request for a team March 2, 2023 23:16
Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you~

do you think there is value in splitting this out into a Go package? I kind of want it for a side project 😅

@samcoe
Copy link
Contributor Author

samcoe commented Mar 5, 2023

@vilmibm Potentially. It is specific to how GitHub does encoding of these values though. We might be doing it a standardized way, haven't heard from the platform team about that yet. Perhaps it belongs in go-gh.

@samcoe samcoe merged commit 44b0218 into trunk Mar 7, 2023
@samcoe samcoe deleted the ascii-2 branch March 7, 2023 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants