Skip to content

Made it possible to do open num only commit hash with Browse Command#7038

Merged
vilmibm merged 1 commit intocli:trunkfrom
yanskun:feat/add-open-num-commit-hash
Mar 1, 2023
Merged

Made it possible to do open num only commit hash with Browse Command#7038
vilmibm merged 1 commit intocli:trunkfrom
yanskun:feat/add-open-num-commit-hash

Conversation

@yanskun
Copy link
Contributor

@yanskun yanskun commented Feb 25, 2023

A short commit hash, such as git log --oneline.
This also has a numeric-only hash value.

If I use them as arguments to gh browse it tries to open an issue and fails.
so sad i fixed it.

I made it possible to use it by using it together with Option --commit.
It's a problem when you have filenames that consist only of numbers,
but that's okay😜

@yanskun yanskun requested a review from a team as a code owner February 25, 2023 14:28
@yanskun yanskun requested review from vilmibm and removed request for a team February 25, 2023 14:28
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Feb 25, 2023
@cliAutomation
Copy link
Collaborator

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

@yanskun
Copy link
Contributor Author

yanskun commented Feb 25, 2023

Sorry. I couldn't find similar Issue.

Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is a nice improvement

@vilmibm vilmibm merged commit fe78331 into cli:trunk Mar 1, 2023
@yanskun yanskun deleted the feat/add-open-num-commit-hash branch March 2, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants