Skip to content

Fix: Include new-line after existing fork error log#7030

Merged
samcoe merged 3 commits intocli:trunkfrom
digitalfu:fix-exisiting-fork-log
Feb 28, 2023
Merged

Fix: Include new-line after existing fork error log#7030
samcoe merged 3 commits intocli:trunkfrom
digitalfu:fix-exisiting-fork-log

Conversation

@digitalfu
Copy link
Contributor

This is a trivial fix for a missing \n and the end of the fork command error log when used with the --clone flag.
e.g.

...already exists.Cloning...

@digitalfu digitalfu requested a review from a team as a code owner February 22, 2023 19:56
@digitalfu digitalfu requested review from samcoe and removed request for a team February 22, 2023 19:56
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Feb 22, 2023
@cliAutomation
Copy link
Collaborator

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samcoe samcoe enabled auto-merge (squash) February 22, 2023 21:01
@samcoe samcoe merged commit 394b23a into cli:trunk Feb 28, 2023
@digitalfu
Copy link
Contributor Author

No No, thank you!
Might I ask in what instances gh gets called without tty? internal calls I thought maybe.

@samcoe
Copy link
Contributor

samcoe commented Mar 1, 2023

@digitalfu When gh is used in a script it gets called without a tty, so when the code refers to no-tty it generally means scripting purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants