Merged
Conversation
With this upgrade our codebase adopts the stricter handling of `os/exec` command lookup in it that it doesn't allow shelling out to a command in the current directory.
samcoe
approved these changes
Dec 12, 2022
Member
|
@mislav - for codespaces, the diff is fine, just mocks. Do we have any concerns about behavioral changes from the new |
Contributor
Author
|
@cmbrose No behavioral changes expected; from our codebase we don't use |
Contributor
|
Your devcontainer.json change looks good too |
cmbrose
approved these changes
Dec 12, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main feature we're opting into with this upgrade is the stricter
os/execbehavior: Go 1.19 will no longer look up executables in the current directory by default (in addition to looking up PATH).See https://github.com/cli/safeexec#readme for more information.
From our own code, we can still continue to explicitly use
safeexecinstead ofos/exec; the added bonus is that we then continue to support relative directory entries in PATH.