show repository name without owner#6160
Merged
Conversation
samcoe
suggested changes
Aug 31, 2022
Contributor
samcoe
left a comment
There was a problem hiding this comment.
Overall the code looks good to me, thanks for the contribution. Only change I would like to see is that we only change the non-tty results i.e. pkg/search/result.go. I think changing what is displayed on the terminal magically based query parameters could lead to confusion.
Contributor
Author
|
Ok, I've removed the tty related changes. @samcoe |
samcoe
approved these changes
Sep 1, 2022
Contributor
samcoe
left a comment
There was a problem hiding this comment.
This is great. Thanks for making the requested changes!
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6155