Fix browse issue with leading hashtag#6144
Merged
Conversation
|
Thank you for picking up the issue.
❯ bin/gh pr view '#8' -wR cli/cli
Opening github.com/cli/cli/pull/8 in your browser.
❯ bin/gh issue view '#8' -wR cli/cli
Opening github.com/cli/cli/pull/8 in your browser.
❯ bin/gh browse '#8' -wR cli/cli
Opening github.com/cli/cli/issues/8 in your browser.
❯ bin/gh browse '#8' -wR cli/cli -n
https://github.com/cli/cli/issues/8
$ gh browse 217
#=> Open issue or pull request 217
$ gh browse #217
#=> Open issue or pull request 217❯ bin/gh browse #217
Opening github.com/cli/cli in your browser.
❯ bin/gh browse '#217'
Opening github.com/cli/cli/issues/217 in your browser. |
Contributor
Author
|
About issues/pull url, I think GitHub will redirect to the correct link anyway. Not sure if I should change this behavior. |
Contributor
Author
|
In this PR, I just handle the leading I think I need an opinion from the team. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6095.