Mention possible need for sudo -E to run make install#6127
Merged
Conversation
Collaborator
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
Contributor
|
I admin merged because the checks all hung with no visible way to kickstart them; they were not even needed, though, given that this is purely a docs change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation mentions that
make installmay requiresudoto run. However,sudo make installwill run Go commands with root's Go environment (e.g. /root/.config/go/env), which may not match the user's Go environment used to runmake(e.g. ~/.config/go/env). This is a problem if the user's Go environment contains options such asGOPROXY=directwhose absence will cause build/install to fail.sudo -E make installwill work around this issue in those sorts of situations, and I propose this warrants a bit more elaboration in the documentation comments.