Conversation
Collaborator
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
samcoe
approved these changes
Aug 31, 2022
Contributor
samcoe
left a comment
There was a problem hiding this comment.
This looks good to me. Thanks for adding tests!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem statement:
If a release does not have a newline at the end of its body, that will affect the way the
ghcommand prints its output in a machine-readable format and results in the next command's output being printed on the same line. This is undesirable even if the body has no trailing newline.For example, given the following commands:
...the output will be:
...when it should be:
No only is this behavior undesirable, it is inconsistent with the way the release is printed when viewed in the human readable format. For example, given the exact same commands (but run in a TTY), the output will print 2 new lines below the release body regardless if it has a trailing newline:
Proposed change:
This fix prints a newline at the end of the release regardless if the release body has a newline or not, by checking to see if a newline is present at the end of the body and if not, printing one.