Skip to content

Add previous-tag flag for generating release notes in gh release create#6107

Merged
samcoe merged 4 commits intocli:trunkfrom
vbh:previous-tag
Sep 6, 2022
Merged

Add previous-tag flag for generating release notes in gh release create#6107
samcoe merged 4 commits intocli:trunkfrom
vbh:previous-tag

Conversation

@vbh
Copy link
Contributor

@vbh vbh commented Aug 19, 2022

Closes #5963

@vbh vbh requested a review from a team as a code owner August 19, 2022 17:15
@vbh vbh requested review from vilmibm and removed request for a team August 19, 2022 17:15
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Aug 19, 2022
@pkleanthous
Copy link

@samcoe @mislav Would you kindly support this PR? This is a fantastic feature to include.

@samcoe samcoe self-assigned this Sep 1, 2022
@samcoe samcoe self-requested a review September 1, 2022 11:54
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vbh Thanks for getting started on this feature. I pushed a commit that simplifies the implementation a bit and reduces changes to existing logic. Also I added a couple more tests to cover all the cases.

@samcoe samcoe enabled auto-merge (squash) September 6, 2022 11:23
@samcoe samcoe merged commit 9fddb07 into cli:trunk Sep 6, 2022
@pkleanthous
Copy link

Thank you guys! @samcoe @vbh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support --previous-tag flag for generating release notes in gh release create

4 participants