Skip to content

Avoid HTML-escaping gh api JSON output#5989

Merged
mislav merged 1 commit intotrunkfrom
api-no-json-htmlescape
Jul 25, 2022
Merged

Avoid HTML-escaping gh api JSON output#5989
mislav merged 1 commit intotrunkfrom
api-no-json-htmlescape

Conversation

@mislav
Copy link
Contributor

@mislav mislav commented Jul 25, 2022

json.Marshal does HTML-escaping by default, which is what we don't want since we're printing to the terminal instead of embedding this JSON into a HTML document.

Fixes #5982

json.Marshal does HTML-escaping by default, which is what we don't want since we're printing to the terminal instead of embedding this JSON into a HTML document.
@mislav mislav requested a review from a team as a code owner July 25, 2022 11:15
@mislav mislav requested review from samcoe and removed request for a team July 25, 2022 11:15
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mislav mislav merged commit 96d6483 into trunk Jul 25, 2022
@mislav mislav deleted the api-no-json-htmlescape branch July 25, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

& displays as \u0026

2 participants