Skip to content

Fix login flow#5928

Merged
samcoe merged 2 commits intotrunkfrom
fix-login-flow
Jul 12, 2022
Merged

Fix login flow#5928
samcoe merged 2 commits intotrunkfrom
fix-login-flow

Conversation

@samcoe
Copy link
Contributor

@samcoe samcoe commented Jul 12, 2022

This PR fixes a bug where the authentication token was not properly being passed to the API client in the login flow causing users to not be able to log in.

Also fixes a small bug in config set where the value was also being set in the hosts file despite no hostname being supplied.

Closes #5927

@samcoe samcoe requested a review from a team as a code owner July 12, 2022 13:26
@samcoe samcoe self-assigned this Jul 12, 2022
@samcoe samcoe requested review from mislav and removed request for a team July 12, 2022 13:26
@samcoe samcoe merged commit 1e8cb9c into trunk Jul 12, 2022
@samcoe samcoe deleted the fix-login-flow branch July 12, 2022 13:46
@jongio
Copy link

jongio commented Jul 12, 2022

Thank you for the fast turnaround on this!

@xqm32 xqm32 mentioned this pull request Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unable to login using gh auth login

2 participants