Added Arm64 compilation #5715
Merged
Added Arm64 compilation #5715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mislav
approved these changes
Jun 20, 2022
Contributor
mislav
left a comment
There was a problem hiding this comment.
Thank you! You are right— we'd need to extend our release automation to build the ARM64 MSI as well, so that would be a bit more work. But at least with this there will already be a (signed) exe in a zip archive 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #2545
There is still work needed for automating the release (sign, build msi, etc) into the releases.yml file, but this should at least build the exe into the artifacts, as well as allow users to use arm64 extensions.