Skip to content

Consistent punctuation in command usages#5139

Merged
mislav merged 3 commits intocli:trunkfrom
kevhlee:lets-be-punctual-part2
Jan 31, 2022
Merged

Consistent punctuation in command usages#5139
mislav merged 3 commits intocli:trunkfrom
kevhlee:lets-be-punctual-part2

Conversation

@kevhlee
Copy link
Contributor

@kevhlee kevhlee commented Jan 31, 2022

Hello,

I made the punctuation more consistent across the different long command descriptions. Specifically, I made sure that the long descriptions utilize periods to distinguish them from short ones. I also made some minor spelling, grammatical, and spacing corrections.

I think the changes I'm making are harmless enough that I do not need to open up an issue, but let me know if that's not the case. Let me know if I need to make any adjustments.

Thanks,
Kevin

@kevhlee kevhlee requested a review from a team as a code owner January 31, 2022 03:33
@kevhlee kevhlee requested review from vilmibm and removed request for a team January 31, 2022 03:33
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Jan 31, 2022
@cliAutomation
Copy link
Collaborator

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

@kevhlee
Copy link
Contributor Author

kevhlee commented Jan 31, 2022

Also, while going through the documentation, I noticed that the gh manual/docs (https://cli.github.com/manual) displays long descriptions from short descriptions differently. Specifically, a command displays a long description after the usage whereas a short description is displayed before the usage. It seems that the short description is used for the command a long one does not exist.

Example:

Is this intentional? To me, this looks strange, at least in the case of gh alias.

Let me know if I should open up an issue to discuss this topic.

Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good! Thank you

@mislav mislav enabled auto-merge (squash) January 31, 2022 10:49
@mislav mislav merged commit 0d143ca into cli:trunk Jan 31, 2022
@waldyrious
Copy link
Contributor

It seems that the short description is used for the command a long one does not exist.

@kevhlee can you clarify this sentence, please? I'm not sure I understood what it's saying.

@mislav
Copy link
Contributor

mislav commented Feb 1, 2022

Specifically, a command displays a long description after the usage whereas a short description is displayed before the usage. It seems that the short description is used for the command a long one does not exist.

@kevhlee This is intentional. I've reviewed the examples you've shared and it doesn't seem particularly jarring to me! The idea is that the command usage line is presented early in the documentation; that's why the long description is only shown after.

@kevhlee
Copy link
Contributor Author

kevhlee commented Feb 1, 2022

Hi @mislav and @waldyrious,

@kevhlee This is intentional. I've reviewed the examples you've shared and it doesn't seem particularly jarring to me! The idea is that the command usage line is presented early in the documentation; that's why the long description is only shown after.

I see. Thanks for the clarification/confirmation! Just wanted to make sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants