Skip to content

Add new line after error#5124

Merged
samcoe merged 3 commits intocli:trunkfrom
audreee:trunk
Feb 1, 2022
Merged

Add new line after error#5124
samcoe merged 3 commits intocli:trunkfrom
audreee:trunk

Conversation

@audreee
Copy link
Contributor

@audreee audreee commented Jan 28, 2022

Fixes #5123

This quick fix adds a new line character after "failed to run extension" errors

@audreee audreee changed the title [DRAFT] Add new line [DRAFT] Add new line after error Jan 28, 2022
@mislav
Copy link
Contributor

mislav commented Jan 31, 2022

Good catch! Is there something missing from this before it's marked as "ready"?

@audreee audreee marked this pull request as ready for review January 31, 2022 17:49
@audreee audreee requested a review from a team as a code owner January 31, 2022 17:49
@audreee audreee requested review from mislav and removed request for a team January 31, 2022 17:49
@audreee audreee changed the title [DRAFT] Add new line after error Add new line after error Jan 31, 2022
@cliAutomation cliAutomation added the external pull request originating outside of the CLI core team label Jan 31, 2022
@audreee
Copy link
Contributor Author

audreee commented Jan 31, 2022

Good catch! Is there something missing from this before it's marked as "ready"?

@mislav it looks like there might be a similar missing \n on line 148 above. Would you prefer I add the fix to this PR or open up a separate issue/PR?

@samcoe samcoe merged commit 1ec2c08 into cli:trunk Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing new line after error message

4 participants