Repo name suggestions for cs create#5108
Merged
Conversation
cmbrose
commented
Jan 27, 2022
adonovan
reviewed
Jan 27, 2022
Contributor
adonovan
left a comment
There was a problem hiding this comment.
Code looks fine. Lots of minor Go style nits.
Member
Author
|
Thanks @adonovan for the feedback and tips! It was very helpful 🎉 |
mislav
suggested changes
Jan 28, 2022
Contributor
mislav
left a comment
There was a problem hiding this comment.
This looks good! There is some wonky handling of keyboard shortcuts when it comes to search suggestions in Survey, but that's up to the upstream library and not your implementation. I would say that this can ship even without improvements to Survey and I left some polish-level comments.
mislav
approved these changes
Jan 31, 2022
Contributor
mislav
left a comment
There was a problem hiding this comment.
Looks great! Thank you for the updates 👍
Tr1985
reviewed
Apr 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5093
Adds the ability to
tabwhile entering the repo name in thecs createcommand in order to get suggestions. Suggestions are populated from thesearch/repositoriesAPI.