Skip to content

Fix filtering issues by milestone#5040

Merged
mislav merged 1 commit intotrunkfrom
issues-by-milestone-fix
Jan 21, 2022
Merged

Fix filtering issues by milestone#5040
mislav merged 1 commit intotrunkfrom
issues-by-milestone-fix

Conversation

@mislav
Copy link
Contributor

@mislav mislav commented Jan 14, 2022

The milestone filter in the Repository.issues GraphQL connection is broken, so switch to the Search API for any milestone filtering.

Previously, we used to work around this by obtaining the milestone database ID from decoding the GraphQL ID, but that no longer works since the GraphQL ID format has changed.

Fixes #4040
Followup to #1462

The milestone filter in the `Repository.issues` GraphQL connection is
broken, so switch to the Search API for any milestone filtering.

Previously, we used to work around this by obtaining the milestone
database ID from decoding the GraphQL ID, but that no longer works since
the GraphQL ID format has changed.
@mislav mislav requested a review from a team as a code owner January 14, 2022 14:12
@mislav mislav requested review from vilmibm and removed request for a team January 14, 2022 14:12
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mislav mislav merged commit 4340c65 into trunk Jan 21, 2022
@mislav mislav deleted the issues-by-milestone-fix branch January 21, 2022 13:47
@mislav
Copy link
Contributor Author

mislav commented Feb 8, 2022

Update: GitHub API has now added the milestoneNumber parameter that properly supports passing milestone numbers as filter for the Repository.issues connection. Currently, we have worked around our issue by switching to the Search API, but if we ever want to switch back to the connection, we can now do that for GitHub.com as long as we keep the Search behavior as fallback for GHES.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gh issue list ... --milestone [value] -> illegal base64 data at input byte 2

2 participants