Conversation
|
@vilmibm This is ready for review. Do let me know if any changes are required :) |
|
@vilmibm just wanted to know if any more changes are required here :) |
vilmibm
left a comment
There was a problem hiding this comment.
thank you for this! I pushed a small commit; without it, I ran into a race condition where we tried to rename before the fork actually existed. I also think being explicit about the fact that this is a fork then a rename is a good thing, so I changed the logging to reflect that.
|
Just a small note for those who may come to this PR (e.g. from the release notes) and didn't see the corresponding issue: This option affects the name of the repository on github (e.g. johndoe/custom-fork-name), rather than the local name of the fork remote. The latter is accomplished via the |
This PR adds the functionality to add a
--fork-nameflag to specify what the final name of the forked repo should be. Since the Github API doesn't yet support this automatically via the Fork API, we fork it and later rename it via the Rename API.Fixes #4849