pr view: ensure that PR reviews are always rendered in --comments mode#4848
Merged
pr view: ensure that PR reviews are always rendered in --comments mode#4848
--comments mode#4848Conversation
The GraphQL query for review didn't use to request the `TotalCount` field, but that field was checked before rendering the conversation thread in `pr view --comments`. This fixes rendering the conversation thread when a PR only has reviews but no ordinary comments.
samcoe
approved these changes
Dec 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GraphQL query for review didn't use to request the
TotalCountfield, but that field was checked before rendering the conversation thread inpr view --comments. This fixes rendering the conversation thread when a PR only has reviews but no ordinary comments.cli/pkg/cmd/pr/view/view.go
Line 227 in a6380c8
Fixes #4841