Ignore scope suggestions for http 422#4809
Merged
Conversation
HTTP 422 messages are for validation errors, but OAUTH permissions suggestions get printed anyways. Most times, the user probably has the right permissions. This fix adds the check to avoid printing a confusing message. Fixes cli#4624
mislav
suggested changes
Nov 25, 2021
cmd/gh/main.go
Outdated
| } else if strings.Contains(err.Error(), "Resource protected by organization SAML enforcement") { | ||
| fmt.Fprintln(stderr, "Try re-authenticating with: gh auth refresh") | ||
| } else if msg := httpErr.ScopesSuggestion(); msg != "" { | ||
| } else if msg := httpErr.ScopesSuggestion(); msg != "" && httpErr.StatusCode != 422 { |
Contributor
There was a problem hiding this comment.
Could you move the "not 422" check into ScopesSuggestion function itself? It's where it performs the check that this should be done for HTTP 4xx in the first place. Thank you!
mislav
approved these changes
Dec 1, 2021
Contributor
mislav
left a comment
There was a problem hiding this comment.
Thanks! I have pushed an additional commit to move the check to where I meant; sorry that I didn't explain myself too well.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HTTP 422 messages are for validation errors, but OAUTH permissions
suggestions get printed anyways. Most times, the user probably has the
right permissions. This fix adds the check to avoid printing a confusing
message.
Fixes #4624