Skip to content

Don't swallow duplicate key error#4807

Merged
mislav merged 2 commits intocli:trunkfrom
despreston:4792-err-dupe-key
Nov 25, 2021
Merged

Don't swallow duplicate key error#4807
mislav merged 2 commits intocli:trunkfrom
despreston:4792-err-dupe-key

Conversation

@despreston
Copy link
Contributor

When adding a key that belongs to another account, an error should be
propagated.

Fixes #4792

When adding a key that belongs to another account, an error should be
propagated.

Fixes cli#4792
@despreston despreston requested a review from a team as a code owner November 24, 2021 18:04
@despreston despreston requested review from samcoe and removed request for a team November 24, 2021 18:04
@despreston despreston requested a review from a team as a code owner November 24, 2021 18:37
Copy link
Contributor

@samcoe samcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the fix!

Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uploading an existing key to a new account fails silently

3 participants