Conversation
- doing mkdir before `git init <dir>` is not necessary; git will create the directory if it doesn't exist - passing both `-C` and `--git-dir` is not needed for git invocations - reading the current working directory isn't necessary for specifying nested paths to operate in - use `git add .` instead of explicitly naming all paths; we generate a gitignore for binaries that we want to avoid adding - generate cross-platform gitignore for Go binary extensions - add helpers to simplify writing files, tests
samcoe
approved these changes
Nov 29, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git init <dir>is not necessary; git will create the directory if it doesn't exist-Cand--git-diris not needed for git invocationsgit add .instead of explicitly naming all paths; we generate a gitignore for binaries that we want to avoid addingFollowup to #4718