Replace shurcool/graphql with cli/shurcool-graphql#4750
Merged
Conversation
8dd39d4 to
260716a
Compare
samcoe
commented
Nov 17, 2021
| teams, err := OrganizationTeams(client, repo) | ||
| // TODO: better detection of non-org repos | ||
| if err != nil && !strings.HasPrefix(err.Error(), "Could not resolve to an Organization") { | ||
| if err != nil && !strings.Contains(err.Error(), "Could not resolve to an Organization") { |
Contributor
Author
There was a problem hiding this comment.
This was already super fragile checking an error message string, luckily we had tests to catch this since the new library slightly changes the error message format. I did a quick search and I think these are the only two places that should be effected by that.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
shurcool/graphqlmodule withcli/shurcool-graphql.cc #1389