Skip to content

Add prebuild availability status to create codespaces#4737

Merged
mislav merged 4 commits intotrunkfrom
codespaces/add-prebuild-availability-status
Nov 17, 2021
Merged

Add prebuild availability status to create codespaces#4737
mislav merged 4 commits intotrunkfrom
codespaces/add-prebuild-availability-status

Conversation

@adnamalin
Copy link
Contributor

What Does This Do?

  • Adds copy to the machine list when a prebuild is ready for a machine during the gh cs create command. A prebuild is ready when the API returns pool or blob.
  • I'm new to Go so extra 👀 much appreciated!
  • Closes: internal codespaces#4702

Screenshots 📷

Screen.Recording.2021-11-16.at.1.12.07.PM.mov

@adnamalin adnamalin marked this pull request as ready for review November 16, 2021 20:02
@adnamalin adnamalin requested a review from a team as a code owner November 16, 2021 20:02
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I would just not use color in select menus until there is better support for it.

Copy link
Contributor

@josebalius josebalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to @mislav on the use of color, otherwise looks good to me! Thanks for the tests.

Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙇

@mislav mislav merged commit 15c8f29 into trunk Nov 17, 2021
@mislav mislav deleted the codespaces/add-prebuild-availability-status branch November 17, 2021 18:41
@VictorBatta VictorBatta mentioned this pull request Dec 4, 2021
@JLeander85

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants