Skip to content

Add gh config list#4729

Merged
vilmibm merged 5 commits intotrunkfrom
config-list
Dec 1, 2021
Merged

Add gh config list#4729
vilmibm merged 5 commits intotrunkfrom
config-list

Conversation

@meiji163
Copy link
Contributor

@meiji163 meiji163 commented Nov 15, 2021

Fixes #859

gh config list pretty prints plain prints key=value list of main config options

  • doesn't show custom config entries
  • doesn't show aliases (use gh alias list instead)

@meiji163 meiji163 requested a review from a team as a code owner November 15, 2021 22:31
@meiji163 meiji163 requested review from mislav and removed request for a team November 15, 2021 22:31
@meiji163 meiji163 changed the title Add gh config list [WIP] Add gh config list Nov 15, 2021
@meiji163 meiji163 changed the title [WIP] Add gh config list Add gh config list Nov 16, 2021
@meiji163
Copy link
Contributor Author

Recap of discussion with @mislav :

  • it's better to always have simple key=value printing so the config list can be parsed programmatically, like in git config --list
  • yaml output is hard to parse with multi-line values
  • users can define custom config entries, but for now just show the ones in config.ConfigOptions

Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gh config list

2 participants