codespace: Rename errors from Live Share to generic codespace#4705
codespace: Rename errors from Live Share to generic codespace#4705josebalius merged 1 commit intotrunkfrom
Conversation
adonovan
left a comment
There was a problem hiding this comment.
This seems fine locally, but I suspect it may lead to the construction of errors that are both repetitive ("connecting to codespace: connecting to codespace: ...") and ambiguous: there are multiple control paths that might result in an error with the prefix "connecting to codespace: ...".
Ideally an integration test suite would assert the text of the errors in specific scenarios, causing us to consider and disambiguate them. In the absence of that integration test suite, please be on the lookout for opportunities to improve unclear error messages as they arise.
mislav
left a comment
There was a problem hiding this comment.
Agreed that Live Share is an implementation detail and as such, the user doesn't have to be aware of it.
Re: repetitive messages in wrapped errors: let's see how this turns out. If the final error messaging proves to be redundant, we can polish that subsequently.
Closes internal issue codespaces#4496
Removes mention of Live Share in error messages shown to users.