Skip to content

fix branch flag on browse within dir#4676

Merged
mislav merged 5 commits intocli:trunkfrom
bstncartwright:browse-branch-dir
Nov 4, 2021
Merged

fix branch flag on browse within dir#4676
mislav merged 5 commits intocli:trunkfrom
bstncartwright:browse-branch-dir

Conversation

@bstncartwright
Copy link
Contributor

Fixes #4666

If there is no selector provided in gh browse --branch my-branch, we should open to the repos home with that branch selected, not the directory they are in.

@bstncartwright bstncartwright requested a review from a team as a code owner November 3, 2021 18:16
@bstncartwright bstncartwright requested review from mislav and removed request for a team November 3, 2021 18:16
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on!

Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you; the update looks great! One tiny thing about tests

Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mislav mislav enabled auto-merge (squash) November 4, 2021 14:57
@mislav mislav merged commit dd0edc8 into cli:trunk Nov 4, 2021
@bstncartwright bstncartwright deleted the browse-branch-dir branch November 4, 2021 15:00
@VictorBatta VictorBatta mentioned this pull request Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gh browse --branch doesn't open repo home

2 participants