Conversation
Contributor
Author
samcoe
suggested changes
Nov 10, 2021
Contributor
samcoe
left a comment
There was a problem hiding this comment.
Good work! I left a handful of comments, nothing major though.
pkg/cmd/repo/archive/archive_test.go
Outdated
| }, | ||
| { | ||
| name: "no argument", | ||
| name: "no arguments tty", |
Contributor
There was a problem hiding this comment.
Suggested change
| name: "no arguments tty", | |
| name: "no arguments no tty", |
Contributor
There was a problem hiding this comment.
We should also have the case where it is tty and there is not an error.
samcoe
approved these changes
Nov 12, 2021
Contributor
samcoe
left a comment
There was a problem hiding this comment.
Great work! Thanks for making the requested changes.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4590