Conversation
added 2 commits
October 19, 2021 14:25
samcoe
approved these changes
Oct 20, 2021
Contributor
samcoe
left a comment
There was a problem hiding this comment.
This looks good. I left two non-blocking comments. Nice work!
pkg/cmd/extension/manager.go
Outdated
| var externalCmd *exec.Cmd | ||
|
|
||
| if runtime.GOOS == "windows" { | ||
| if ext.IsBinary() { |
Contributor
There was a problem hiding this comment.
Suggested change
| if ext.IsBinary() { | |
| if ext.IsBinary() || runtime.GOOS != "windows" { | |
| ... | |
| } else { | |
| ... | |
| } |
Looks like this if statement could be simplified a bit.
| return true | ||
| } | ||
|
|
||
| func (e *Extension) IsBinary() bool { |
Contributor
There was a problem hiding this comment.
There is one place in extension/manager.go:480 that this same check is taking place, can we replace the check with this function?
Contributor
There was a problem hiding this comment.
Oh I actually found another use case for it. If we switch around the if statement at extension/manager.go:271 we can reuse this function, that way we are never directly checking ext.kind outside of this function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR skips the
shwrapper on all platforms when dispatching a binary extension.I'm still punting on local installs.