People doesn't want to publish release when specify -d option#4542
Merged
People doesn't want to publish release when specify -d option#4542
Conversation
mislav
reviewed
Oct 18, 2021
Contributor
mislav
left a comment
There was a problem hiding this comment.
Good catch! Agreed that it was weird to default to "Publish release" if you specified --draft when invoking the command.
However, since we're in interactive mode anyway, I see no harm in allowing "Publish release". Maybe a user could change their mind since specifying --draft? How would you feel about keeping the selection options as-is, but just have a default of "Save as draft" if --draft was given? You can define a Default field in the survey.Select struct.
30f45f6 to
c7f79e8
Compare
Contributor
Author
|
@mislav Thank you for you review. I did change to set default of publish action. |
…unsynced with default value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4541