Skip to content

Removing "friendly" machine name from prompt#4538

Merged
asciimike merged 5 commits intotrunkfrom
mm-codespaces-remove-friendly-machine-name
Oct 18, 2021
Merged

Removing "friendly" machine name from prompt#4538
asciimike merged 5 commits intotrunkfrom
mm-codespaces-remove-friendly-machine-name

Conversation

@asciimike
Copy link
Contributor

Currently the options end up as Basic through to X. No other client provides these types of names, so we should just show machine info.

E.g. see VSCode:

image

Currently the options end up as `Basic` through to `X`. No other client
provides these types of names, so we should just show machine info.
@asciimike asciimike requested a review from a team as a code owner October 15, 2021 21:58
@cliAutomation
Copy link
Collaborator

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

@asciimike asciimike requested a review from a team as a code owner October 15, 2021 22:08
@asciimike asciimike requested review from vilmibm and removed request for a team October 15, 2021 22:08
Copy link
Contributor

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a fan of this consistency between editors.

Just a thought (not blocking): do we reference machines by name ("Small", "Extreme", etc.) in docs anywhere in general (I'm thinking for pricing), and if so should we get rid of that too?

EDIT: I answered my own question, nope, we don't show "Small", "Extreme", whatever anywhere else that I can find in docs or in other UIs. 🙌🏻

@asciimike
Copy link
Contributor Author

I answered my own question, nope, we don't show "Small", "Extreme", whatever anywhere else that I can find in docs or in other UIs.

Correct, we don't reference them anywhere in the docs, etc.

Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simpler is often better! 👍

@asciimike asciimike merged commit 5bf185c into trunk Oct 18, 2021
@asciimike asciimike deleted the mm-codespaces-remove-friendly-machine-name branch October 18, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants