Conversation
|
Usage is based on the extension https://github.com/mislav/gh-delete-repo . To confirm deletion user types the full repo name, or passes in |
samcoe
left a comment
There was a problem hiding this comment.
This is looking great so far! Left some comments/questions for discussion.
vilmibm
left a comment
There was a problem hiding this comment.
This is coming along great! In addition to Sam's observations, I have one more request:
It'd be great to notice when the API call 403s and suggest that the user run gh auth refresh -sdelete_repo to fix it; for all other HTTP error status codes, just printing the error as is done now is fine.
I originally had this and @mislav suggested that it wasn't necessary. He said he is working on general scope error handling. Should I put it in for now? |
mislav
left a comment
There was a problem hiding this comment.
Looks great! One last bit about error handling
Co-authored-by: Mislav Marohnić <mislav@github.com>
|
sorry for my confusion: I read in the error handling PR that this case wouldn't be handled and then, locally, didn't realize that trunk hadn't been merged into this PR so I didn't see the new behavior. Sorry for all the churn. |
|
Since @mislav 's final change request was addressed, I'm going to go ahead and merge this. |
|
Thanks for adding the feature 🥳🥳🎉🎉 |
|
Add
gh repo deletecommand. Fixes #3625