- Add new flag --no-store to print the encoded secret in "secret set"#4423
- Add new flag --no-store to print the encoded secret in "secret set"#4423
Conversation
mislav
left a comment
There was a problem hiding this comment.
Thank you! This feature as you've made it looks good, but I'm still on the fence whether this belongs in gh secret set. More thoughts below
pkg/cmd/secret/set/set.go
Outdated
| $ gh secret set MYSECRET < file.json | ||
|
|
||
| Print encoded secret value | ||
| $ gh secret set MYSECRET --no-store |
There was a problem hiding this comment.
It feels weird to have to specify the secret variable name even in the case when the value is not going to be stored. Maybe this is reason enough to move this functionality to be its own command rather than an extra flag in secret set? But please don't make this change yet— I would first like to hear more thoughts from people in my team and potentially other users about this. Please be patient until we reach a decision 🙇
|
@mislav All changes setup, the only thing left is to define whether we need this in another command or here :) |
- Add tests for new flag using contains as a valid assertion in it
ca0966e to
ff89c6d
Compare
|
@mislav any updates on this pending PR? |
mislav
left a comment
There was a problem hiding this comment.
Looks good! Pushed a few polish-level items and the ability to avoid specifying the secret name when using --no-store, since it's not needed in that mode
Fixes #4388