pr status: show number of approvals#4240
Merged
Conversation
This commit changes the approval count in the PR status command so that it only counts the most recent review from each reviewer.
If the base branch has no minimum approval requirements, show "N Approved" reviews. Otherwise, show "N/X Approved".
mislav
reviewed
Aug 30, 2021
| @@ -0,0 +1,46 @@ | |||
| package login | |||
Contributor
There was a problem hiding this comment.
This code looks like it doesn't belong in this PR. You can take it out and force-push to your branch.
f84b8b5 to
8cba1ca
Compare
mislav
approved these changes
Jan 21, 2022
Contributor
mislav
left a comment
There was a problem hiding this comment.
I've pushed some fixes. Thank you for your patience!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the total count of PR approvals in the pr status command output.
Closes #2210
Previously #2261