Skip to content

Disable auth for cobra shell request completion hidden commands#4189

Merged
mislav merged 1 commit intocli:trunkfrom
cuonglm:issue-4188
Aug 24, 2021
Merged

Disable auth for cobra shell request completion hidden commands#4189
mislav merged 1 commit intocli:trunkfrom
cuonglm:issue-4188

Conversation

@cuonglm
Copy link
Contributor

@cuonglm cuonglm commented Aug 24, 2021

Those hidden command are used by the shell completion scripts, but they
are not disabled auth check. Thus, the shell completion does not work
even the completion setup was done properly.

Fixes #4188

Those hidden command are used by the shell completion scripts, but they
are not disabled auth check. Thus, the shell completion does not work
even the completion setup was done properly.

Fixes #4188
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you 🙇

@mislav mislav enabled auto-merge August 24, 2021 18:43
@mislav mislav merged commit 355d281 into cli:trunk Aug 24, 2021
@cuonglm cuonglm deleted the issue-4188 branch August 24, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Completion should not require authentication

2 participants