Add branch and actor filters to run list#4100
Conversation
|
Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message. |
|
Anything that still needs to be done before we can get this merged? Id love to utilize this :) |
|
@mislav Can this be moved forward somehow? |
samcoe
left a comment
There was a problem hiding this comment.
@bak1an Thanks for the contribution and sorry for the delay getting this reviewed. Overall really like the approach here I just left one comment about reducing the responsibilities of FilterOptions. Are you still open to adding tests for this? Seems like you were waiting for direction approval before adding those.
|
@samcoe Thanks for a review! I am still around and can update the PR and will try adding tests for this. |
dde5700 to
76d9934
Compare
492179c to
b887455
Compare
|
@samcoe Hi. The PR is now rebased onto fresh trunk, Added checks in Also checking in |
samcoe
left a comment
There was a problem hiding this comment.
@bak1an This is great! Thanks for being thorough with the tests. I like the new query string matcher a lot and I can see it being used in the future. When that happens we can extract it into httpmock. I pushed one small commit to just change the name of the flag from actor to user. Thanks for your contribution.
95a3e42 to
fdd9d7b
Compare
|
Thanks @samcoe 🎉 |
Both https://docs.github.com/en/rest/reference/actions#list-workflow-runs and https://docs.github.com/en/rest/reference/actions#list-workflow-runs-for-a-repository accept those query parameters and seems that it would be handy to have it in cli as well.
upd: Just noticed that there is a related issue #3686, have not seen it initially when opening the PR. Will pause adding tests until getting some initial feedback on the approach taken.