Add interactive mode to auth flow, pass from login and refresh#3997
Merged
Add interactive mode to auth flow, pass from login and refresh#3997
Conversation
This comment was marked as spam.
This comment was marked as spam.
1541f8a to
63a788a
Compare
mislav
approved these changes
Jan 12, 2022
Contributor
mislav
left a comment
There was a problem hiding this comment.
Thank you!
With the initial changes on this branch, running gh auth login non-interactively did not quite work for me, so I've pushed some edits.
Fixes non-interactive login flow and make sure "prompt" configuration is respected by never prompting if it was explicitly disabled. No longer asks to press Enter again after "Authentication complete" message, since that didn't provide any value to the user.
63a788a to
be9f011
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3996
All existing tests pass, also manually tested reproduction steps from the linked issue it now works without interaction.