Merged
Conversation
Allows setting the path to the browser using the config. Closes cli#858
79fe649 to
c95f30a
Compare
samcoe
approved these changes
Aug 17, 2021
Contributor
samcoe
left a comment
There was a problem hiding this comment.
Thanks for the contribution! I added some tests and a little 💅
samcoe
reviewed
Aug 17, 2021
| // Browser precedence | ||
| // 1. browser from config | ||
| // 2. BROWSER | ||
| func browserLauncher(f *cmdutil.Factory) string { |
Contributor
There was a problem hiding this comment.
I extracted this function from browser for testability purposes.
mislav
approved these changes
Aug 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows setting the path to the browser using the config.
Closes #858