Conversation
|
@mislav | @vilmibm As a response to this comment #995 (comment), I've made a design document(link in the header description), a reference to the APIs supported by Github and a mock up dummy flow in the head branch itself. Would love some feedback on this :) |
vilmibm
left a comment
There was a problem hiding this comment.
Awesome work on this delivery! I love how thorough the google doc is.
I chatted with our designer and we agree that given how many things we might expose here, it might be best to do a multiselect to see what the user wants to change instead of asking about each setting.
Mind another design pass that mirrors what pr/issue edit do?
|
@vilmibm thanks for the feedback :) I think this would be a mixture of multi select and a boolean survey. For eg: There are boolean settings like I propose we keep the text fields and options which can have multiple choices like repo visibility as multi select i.e
and boolean settings as a confirm prompt i.e
Would like to hear out your thoughts as well on this. |
|
any thoughts @vilmibm ? |
|
Hey @vilmibm just wanted to do a follow up about your thoughts on this :) |
|
Hey @g14a , Thanks for your patience, sorry for the long delay. Good point about the bool prompts. I like the compromise you suggested--feel free to go for it! |
|
Thanks for the reply @vilmibm I updated the google doc with the heading Google doc - doc Attaching screenshot for reference: Let me know if any changes are need to be made. If the design is convincing, I can start working on the implementation :) |
|
Hey @vilmibm just wanted to get a follow up on the final design iteration :) |
|
Hey @vilmibm I don't mean to hurry but did you find a moment to go through the latest draft attached above? Thank you :) |
|
Hi @g14a, sorry for no communication! We were busy with making other features for gh and we didn't prioritize the The prompt-based I would suggest, though, to start with a non-interactive |
|
@mislav thank you! That's all I needed. On it. |
|
The actual PR can be found at #4318 as this is a design draft. |

This design draft and a dummy flow exposes more repository settings as discussed in #995
Attaching a google document for the design. And the head branch contains a dummy flow for
gh repo editMight close #995
Design doc - Google doc
Attaching screenshots for reference: