Merged
Conversation
639e273 to
b099877
Compare
samcoe
approved these changes
Jun 11, 2021
Contributor
samcoe
left a comment
There was a problem hiding this comment.
This is sooo much better than before! Thanks for taking this on.
mislav
reviewed
Jun 11, 2021
Contributor
mislav
left a comment
There was a problem hiding this comment.
This is great work! Thanks for doing the heavy lifting
| Rename bool | ||
| } | ||
|
|
||
| var Since = func(t time.Time) time.Duration { |
| } | ||
| } | ||
|
|
||
| func runCommand(httpClient *http.Client, remotes []*context.Remote, isTTY bool, cli string) (*test.CmdOut, error) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completely rewrites all of the tests for
gh repo forkto bring them in line with our current testing approach. It additionally fixes some errors that were silently happening in the tests.This is pre-work for some refactoring in
gh repo forkwhich came out of wanting to change the config as discussed in #3091 .I also made some minor non-test changes:
Sincefunction toforkas part of its options struct instead of a package level functionprompt.Confirmstub-able