Thank you!

this code is not the easiest to maintain 😓 so I appreciate you diving into it. I'm actively working on cleaning up this code and its tests and this PR is a helpful step in that direction.

Hi, thank you for the contribution, but we won't be merging this. The code looks okay, but this adds very specific ad-hoc validation to just the --org flag, whereas the problem of passing empty values for flags will remain the same for every other string flag in every other command. As such, I believe that this solution is too narrowly focused.

If we were to solve the problem of users passing invalid flag values (e.g. empty values for string flags that expect a non-empty value, which is most of them), I would much rather see a single solution that solves this across the board (for example, by using Cobra's hooks mechanism) rather than just for the repo fork --org flag. You are welcome to attempt that in a separate PR!

@camillesf I'm sorry for making the decision on this prematurely. There was nothing wrong with your contribution; it's just that I had ideally wanted a solution that encompasses all flags and commands affected by this lack of validation. But of course, we have to start somewhere, and your changeset is a good start. 👍

That's great, thank you! I've rebased to resolve conflicts.

Re: solving this at Cobra-level, I agree. Before doing it this way, I did take a look at cobra and pflags (which were unknown to me) to see if something built-in was available, but I didn't see anything. I'll actually take a look at hooks now, as you hinted—that's a useful pointer, thank you.

Before doing it this way, I did take a look at cobra and pflags (which were unknown to me) to see if something built-in was available, but I didn't see anything

Thanks for checking that. I remember also looking into this, but I don't think either Cobra nor pflag had any facilities for defining flag validation. Even so, I think it could be possible to add validation using Cobra's command hooks. For example, a global pre-run hook could iterate over all value flags that are marked "changed" (i.e. they were explicitly included in the invocation) but whose value is blank or whitespace-only. Then it can report those as an argument processing error. An additional thing left to solve would be how would we explicitly mark some flags as allowing blank values? For example, we will want to allow any value, including blank, for a --body flag.