Skip to content

Add support for removing environment secrets#3774

Merged
mislav merged 1 commit intocli:trunkfrom
browniebroke:feat/remove-env-secret
Jun 3, 2021
Merged

Add support for removing environment secrets#3774
mislav merged 1 commit intocli:trunkfrom
browniebroke:feat/remove-env-secret

Conversation

@browniebroke
Copy link
Contributor

Building on top of #3270 (list env secrets) and #3769 (set env secrets), this adds support for removing environment secrets.

Fixes #3265

Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; thank you!

@mislav mislav merged commit b166376 into cli:trunk Jun 3, 2021
@browniebroke browniebroke deleted the feat/remove-env-secret branch June 3, 2021 14:25
Copy link

@natasha1007 natasha1007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg/cmd/secret/remove/remove_test.go


err := removeRun(opts)
assert.NoError(t, err)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for environment secrets

3 participants