Fix pr checkout for PRs coming from deleted forks#3700
Merged
Conversation
antphyohlyandtun
approved these changes
May 25, 2021
samcoe
reviewed
May 25, 2021
Comment on lines
+99
to
+101
| if pr.HeadRepository == nil { | ||
| headRemote = nil | ||
| } else if pr.IsCrossRepository { |
Contributor
There was a problem hiding this comment.
This is just a short circuit, correct? remotes.FindByRepo was previously returning nil when pr.HeadRepository == nil?
Contributor
Author
There was a problem hiding this comment.
Correct! But now pr.HeadRepository.Name will crash when there is no head repository, so we have to guard against accessing it.
Fix `pr checkout` setting up git push configuration
|
Out of curiosity, why were the other tests moved to become legacy? Makes it impossible to test just one test now, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3696