Just wanted to make sure you saw feedback from @mislav in the issue, so cross-posting it here:

Agreed: that we should not cap the secrets listed to 30 (the default API page limit)
I doubt, however, that we need the --limit option. Unlike the list of issues in a repository or the list or repositories under an organization, secrets is not a set of data that tends to grow indefinitely.

How about always listing all the secrets? I.e. fetching per_page=100 by default and paginating until all results are fetched. I'd be fine with that approach, and I don't think that even the largest repositories/organizations would ever have too many pages so that they would want a limit option.

ah thanks @billygriffin , I missed that. I also agree that --limit is superfluous here.

@g14a let's go that route -- you can drop the --limit flag and just use pagination to fetch all of the secrets each time.

@g14a let's go that route -- you can drop the --limit flag and just use pagination to fetch all of the secrets each time.

On it.

@vilmibm done. Should another test be written for infinite pagination though? I thought that wasn't needed but I'd like to hear what you have to say about that. Hope I didn't make things worse.

I don't mean to hurry you but umm..any thoughts? @vilmibm