Conversation
mislav
approved these changes
May 20, 2021
Contributor
mislav
left a comment
There was a problem hiding this comment.
Already so much better. Thank you!
|
|
||
| **Note**: If you get _"gpg: failed to start the dirmngr '/usr/bin/dirmngr': No such file or directory"_ error, try installing the `dirmngr` package. Run `sudo apt-get install dirmngr` and repeat the steps above. | ||
|
|
||
| **Note**: most systems will have `apt-add-repository` already. If you get a _command not found_ |
Contributor
There was a problem hiding this comment.
Yess all those notes gone 🔥🔥🔥
docs/install_linux.md
Outdated
| ### Debian, Ubuntu Linux (apt) | ||
|
|
||
| Install (Using apt-key): | ||
| :warning: This will only work for the deb-based distributions we [explicitly support](/.github/workflows/releases.yml#L83) and the [architectures we officially support](/.goreleaser.yml#L27). |
Contributor
There was a problem hiding this comment.
Why couldn't we allow anyone with a Debian derivative to fetch our deb package, regardless of what their lsb_release -cs reports? I.e. instead of evaluating lsb_release -cs, we put some static string in sources.list, like "stable".
Contributor
Author
There was a problem hiding this comment.
we can do that, though it can lead to annoying behavior with certain distributions especially around distro upgrade time. I'll put stable for now but leave a note about how a more specific codename can be used if desired.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3513
Fixes #2893
Fixes #1827
This PR removes two tools from our .deb installation docs (apt-key, apt-add-repository). It also links to our GPG key on
cli.github.cominstead of on the ubuntu keyserver.Hopefully this leads to a smoother installation experience across the various .deb distros.
Additionally, this PR adds explicit packaging for Debian Sid (the codename for
unstable). We already packaged for sid, but only listedunstableand notsid. Typically, one could just symlinkunstabletosid(as #1827 suggests) but unfortunately that doesn't work with GitHub Pages. It seems like we could allow symlinking with GitHub pages, but it wasn't immediately clear to me how to do so (or if we ought to). So for now, I've just addedsidto our distributions file.For reference: https://docs.github.com/en/pages/setting-up-a-github-pages-site-with-jekyll/troubleshooting-jekyll-build-errors-for-github-pages-sites#file-is-a-symlink
NB: if we are able to enable the symlinking, I could shorten our
distributionsfile considerably and not require so many code names in the release workflow yaml.