Conversation
GitHub Actions sets a default [GITHUB_REPOSITORY][docs] environment variable with the owner and repository name (e.g. octocat/Hello-World). This commit adds support to read the GITHUB_REPOSITORY environment variable as a fallback when the GH_REPO environment variable is not set. If both environment variables are set, GH_REPO takes precedence over GITHUB_REPOSITORY, mirroring the behavior of GH_TOKEN and GITHUB_TOKEN. [docs]: https://docs.github.com/actions/reference/environment-variables
|
@austindrenski Thank you for the proposal and for the contribution! The code looks great, so congrats on your first Go contribution 🎉 But first, let's talk about the feature itself. #3556 (comment) |
Pyone5
left a comment
There was a problem hiding this comment.
rob@roberts-mbp gh_private2internal % ./main.sh explosion
Showing 99 of 99 repositories in @explosion that match your search
REPONAME Repo powering the API for the Arizona consultancy project private 0m
REPONAME Ontology-based entity detection and linking for the biomedical domain. private 37m
REPONAME_FOR_INTERNAL_REPO private 50m
REPONAME Corpora and other data files for internal spaCy training. private 2h
This comment has been minimized.
This comment has been minimized.
|
@austindrenski Looks like there was resolution on direction that we want to take #3556 (comment). Are you willing to rework this PR to move that direction? Or is it okay to close this PR and give another community member an opportunity to contribute a PR to solve the issue? |
|
Going to close this for now due to lack of response. |
GitHub Actions sets a default
GITHUB_REPOSITORYenvironment variable with the owner and repository name (e.g.octocat/Hello-World).This PR adds support to read the
GITHUB_REPOSITORYenvironment variable as a fallback when theGH_REPOenvironment variable is not set. If both environment variables are set,GH_REPOtakes precedence overGITHUB_REPOSITORY, mirroring the behavior ofGH_TOKENandGITHUB_TOKEN.Fixes: #3556
(This is my first time working in Go, so I've tried to match existing style, but have surely missed something, so very open to any/all nits.)