Skip to content

Improve issue status detection#3525

Merged
mislav merged 2 commits intocli:trunkfrom
cristiand391:improve-issue-status-detection
May 3, 2021
Merged

Improve issue status detection#3525
mislav merged 2 commits intocli:trunkfrom
cristiand391:improve-issue-status-detection

Conversation

@cristiand391
Copy link
Contributor

This PR makes gh rely on the state field to detect the current issue status (either OPEN or CLOSED) instead of the closed field.

See #3351

@cristiand391 cristiand391 force-pushed the improve-issue-status-detection branch from ce2f5c2 to 6b49e21 Compare April 28, 2021 03:31
Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fewer fields in a query is always welcome. 👍

Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second look, let's bring back the Closed struct field. Ref. #3539

@erkkkkkkkkk

This comment was marked as spam.

@erkkkkkkkkk

This comment was marked as spam.

Copy link
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mislav mislav merged commit 25d79c4 into cli:trunk May 3, 2021
@cristiand391 cristiand391 deleted the improve-issue-status-detection branch May 3, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants