Skip to content

add Debian install variant without add-apt-repository#3419

Merged
vilmibm merged 1 commit intocli:trunkfrom
zxaos:patch-1
Apr 20, 2021
Merged

add Debian install variant without add-apt-repository#3419
vilmibm merged 1 commit intocli:trunkfrom
zxaos:patch-1

Conversation

@zxaos
Copy link
Contributor

@zxaos zxaos commented Apr 14, 2021

The Debian docs recommend installing third-party repos with limited keyring scopes these days.

This PR adds a variant to the install instruction for Debian-compatible distros that uses this method (and doesn't require software-properties-common) since add-apt-key is deprecated.

@cliAutomation
Copy link
Collaborator

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.


### Debian, Ubuntu Linux (apt)

Install:

This comment was marked as spam.

Install (without add-apt-repository, with limited keyring scope):
```bash
sudo apt-key --keyring /usr/share/keyrings/githubcli-archive-keyring.gpg adv --keyserver keyserver.ubuntu.com --recv-key C99B11DEB97541F0
echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/githubcli-archive-keyring.gpg] https://cli.github.com/packages $(lsb_release -cs) main" | sudo tee /etc/apt/sources.list.d/github-cli2.list > /dev/null

This comment was marked as spam.

@vilmibm vilmibm self-requested a review April 14, 2021 16:53
@vilmibm
Copy link
Contributor

vilmibm commented Apr 14, 2021

thanks! I'll look into this and do some testing locally. Is there a reason to not standardize on this new suggestion instead of mentioning add-apt-key?

@zxaos
Copy link
Contributor Author

zxaos commented Apr 15, 2021

I don't think there's a reason not to standardize on the newer style, just didn't want to overstep 😀

Copy link
Contributor

@vilmibm vilmibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these new instructions much more :D I will circle back and consolidate this section later.

@vilmibm vilmibm merged commit 5821065 into cli:trunk Apr 20, 2021
@zxaos zxaos deleted the patch-1 branch April 22, 2021 18:53
@slivontii

This comment was marked as spam.

@S69y

This comment was marked as spam.

@mspaansen

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants